fix(rendering): Convert D3D8 ZBIAS integer values to D3D9 DEPTHBIAS floats - #5
Open
bobtista wants to merge 1 commit into
Open
fix(rendering): Convert D3D8 ZBIAS integer values to D3D9 DEPTHBIAS floats#5bobtista wants to merge 1 commit into
bobtista wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D3D8's D3DRS_ZBIAS accepted integer values 0-16. D3D9's D3DRS_DEPTHBIAS
accepts a float encoded as a DWORD. The existing #define mapping makes it
compile but the integer values (7, 8) become near-zero denormalized floats,
so depth bias is effectively always zero.
Adds Set_DX8_ZBias() which converts the legacy integer to a proper float
and updates all GeneralsMD call sites (decal mesh rendering, wireframe
overlay passes). The conversion factor may need visual tuning.